Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: Fix STLFileReader crash bug #930

Merged

Conversation

imikejackson
Copy link
Contributor

  • Original bug was caused by a malformed fmt::format statement with a mismatch '}' character.
  • Added more error checking to ensure we can safely recover from common STL reading errors
  • Updated the documentation to reflect the vendor list that does not write conformant STL Files.

@imikejackson imikejackson requested a review from nyoungbq April 26, 2024 18:53
@imikejackson imikejackson enabled auto-merge (squash) April 26, 2024 18:53
@imikejackson imikejackson force-pushed the topic/stl_file_read_crash branch from 2fd18bd to 3c41d35 Compare April 26, 2024 18:53
- Original bug was caused by a malformed fmt::format statement with a mismatch '}' character.
- Added more error checking to ensure we can safely recover from common STL reading errors
- Updated the documentation to reflect the vendor list that does not write conformant STL Files.

Signed-off-by: Michael Jackson <[email protected]>
@imikejackson imikejackson force-pushed the topic/stl_file_read_crash branch from 3c41d35 to cf5dca1 Compare April 28, 2024 15:01
@imikejackson imikejackson force-pushed the topic/stl_file_read_crash branch from e597e9f to 008188d Compare April 28, 2024 17:59
@imikejackson imikejackson merged commit 7f055a5 into BlueQuartzSoftware:develop Apr 28, 2024
8 checks passed
@imikejackson imikejackson deleted the topic/stl_file_read_crash branch April 29, 2024 02:47
imikejackson added a commit to imikejackson/simplnx that referenced this pull request Oct 20, 2024
- Original bug was caused by a malformed fmt::format statement with a mismatch '}' character.
- Added more error checking to ensure we can safely recover from common STL reading errors
- Updated the documentation to reflect the vendor list that does not write conformant STL Files.

Signed-off-by: Michael Jackson <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants